/
delta.go
371 lines (319 loc) · 10.8 KB
/
delta.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
// Copyright 2018 Intel Corporation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package swupd
import (
"fmt"
"log"
"os"
"os/exec"
"path/filepath"
"sync"
"syscall"
"github.com/clearlinux/mixer-tools/helpers"
"github.com/pkg/errors"
)
const (
// From swupd-server's include/swupd.h:
//
// Approximately the smallest size of a pair of input files which differ by a
// single bit that bsdiff can produce a more compact deltafile. Files smaller
// than this are always marked as different. See the magic 200 value in the
// bsdiff/src/diff.c code.
//
minimumSizeToMakeDeltaInBytes = 200
)
// Delta represents a delta file between two other files. If Error is present, it
// indicates that the delta couldn't be created.
type Delta struct {
Path string
Error error
from *File
to *File
}
// CreateDeltasForManifest creates all delta files between the previous and current version of the
// supplied manifest. Returns a list of deltas (which contains information about
// individual delta errors). Returns error (and no deltas) if it can't assemble the delta
// list. If number of workers is zero or less, 1 worker is used.
func CreateDeltasForManifest(manifest, statedir string, from, to uint32, numWorkers int, bsdiffLog *log.Logger) ([]Delta, error) {
var c config
c, err := getConfig(statedir)
if err != nil {
return nil, err
}
var oldManifest *Manifest
var newManifest *Manifest
if oldManifest, err = ParseManifestFile(filepath.Join(c.outputDir, fmt.Sprintf("%d", from), manifest)); err != nil {
return nil, err
}
if newManifest, err = ParseManifestFile(filepath.Join(c.outputDir, fmt.Sprintf("%d", to), manifest)); err != nil {
return nil, err
}
return createDeltasFromManifests(&c, oldManifest, newManifest, numWorkers, bsdiffLog)
}
// CreateBsdiffLogger creates a logger for the bsdiff_errors.log file at the directory
// specified by stateDir.
func CreateBsdiffLogger(stateDir string) (*log.Logger, *os.File, error) {
logFile, err := os.OpenFile(filepath.Join(stateDir, "bsdiff_errors.log"), os.O_RDWR|os.O_CREATE|os.O_APPEND, 0666)
if err != nil {
return nil, nil, errors.Wrap(err, "Cannot create log file for delta creation")
}
bsdiffLog := log.New(logFile, "DELTA: ", log.Lshortfile)
return bsdiffLog, logFile, nil
}
func createDeltasFromManifests(c *config, oldManifest, newManifest *Manifest, numWorkers int, bsdiffLog *log.Logger) ([]Delta, error) {
deltas, err := findDeltas(c, oldManifest, newManifest)
if err != nil {
return nil, errors.Wrapf(err, "Failed to create deltas list %s", newManifest.Name)
}
if len(deltas) == 0 {
return []Delta{}, nil
}
if numWorkers < 1 {
numWorkers = 1
}
var deltaQueue = make(chan *Delta)
var wg sync.WaitGroup
wg.Add(numWorkers)
// Delta creation takes a lot of memory, so create a limited amount of goroutines.
for i := 0; i < numWorkers; i++ {
go func() {
defer wg.Done()
for delta := range deltaQueue {
delta.Error = createFileDelta(c, delta, bsdiffLog)
}
}()
}
// Send jobs to the queue for delta goroutines to pick up.
for i := range deltas {
deltaQueue <- &deltas[i]
}
// Send message that no more jobs are being sent
close(deltaQueue)
wg.Wait()
return deltas, nil
}
// CreateManifestDeltas creates the delta manifest files for manifests in the from and to version of the
// referenced MoMs. Returns a list of deltas containing information on errors encountered during the
// delta generation process or an error (and no deltas list) if it can't create the deltas.
func CreateManifestDeltas(statedir string, fromManifest, toManifest *Manifest, numWorkers int) ([]Delta, error) {
var c config
var err error
c, err = getConfig(statedir)
if err != nil {
return nil, err
}
bsdiffLog, logFile, err := CreateBsdiffLogger(c.stateDir)
if err != nil {
return nil, errors.Wrap(err, "Cannot create log file for delta creation")
}
defer func() {
_ = logFile.Close()
}()
toManifest.sortFilesName()
fromManifest.sortFilesName()
var deltas []Delta
i := 0
j := 0
toVersion := toManifest.Header.Version
for i < len(fromManifest.Files) && j < len(toManifest.Files) {
f1 := fromManifest.Files[i]
f2 := toManifest.Files[j]
// Only create deltas if the bundle updated in the current version
if f2.Version != toVersion {
i++
j++
continue
}
if f1.Name == f2.Name {
// Manifests wouldn't have the same name but not the same type
if f1.Type != TypeManifest {
i++
j++
continue
}
// Don't create deltas for manifests that aren't changed in the current version
if f1.Version == f2.Version {
i++
j++
continue
}
// Manifests aren't deleted so don't need to check status
deltas = append(deltas, Delta{
Path: filepath.Join(statedir, "www", fmt.Sprintf("%d", toManifest.Header.Version),
fmt.Sprintf("Manifest-%s-delta-from-%d", f1.Name, f1.Version)),
from: f1,
to: f2,
})
i++
j++
} else if f1.Name < f2.Name {
i++
} else {
j++
}
}
if len(deltas) == 0 {
return []Delta{}, nil
}
if numWorkers < 1 {
numWorkers = 1
}
var deltaQueue = make(chan *Delta)
var wg sync.WaitGroup
wg.Add(numWorkers)
// Delta creation takes a lot of memory, so create a limited amount of goroutines.
for i := 0; i < numWorkers; i++ {
go func() {
defer wg.Done()
for delta := range deltaQueue {
delta.Error = createManifestDelta(&c, delta, bsdiffLog)
}
}()
}
// Send jobs to the queue for delta goroutines to pick up.
for i := range deltas {
deltaQueue <- &deltas[i]
}
// Send message that no more jobs are being sent
close(deltaQueue)
wg.Wait()
return deltas, nil
}
// deltaTooLarge returns true if the delta file is larger than or equal in size
// to the compressed fullfile. This is not a critical check so any failures in
// the process just cause a false return.
func deltaTooLarge(c *config, delta *Delta, newPath string) bool {
dInfo, err := os.Stat(delta.Path)
if err != nil {
return false
}
deltaSize := dInfo.Size()
fHash, err := GetHashForFile(newPath)
if err != nil {
return false
}
fCompressed := filepath.Join(c.outputDir,
fmt.Sprint(delta.to.Version),
"files",
fHash+".tar")
fcInfo, err := os.Stat(fCompressed)
if err != nil {
return false
}
fcSize := fcInfo.Size()
return deltaSize >= fcSize
}
func createFileDelta(c *config, delta *Delta, bsdiffLog *log.Logger) error {
oldPath := filepath.Join(c.imageBase, fmt.Sprint(delta.from.Version), "full", delta.from.Name)
newPath := filepath.Join(c.imageBase, fmt.Sprint(delta.to.Version), "full", delta.to.Name)
return createDelta(c, oldPath, newPath, delta, bsdiffLog)
}
func createManifestDelta(c *config, delta *Delta, bsdiffLog *log.Logger) error {
oldPath := filepath.Join(c.stateDir, "www", fmt.Sprint(delta.from.Version), "Manifest."+delta.from.Name)
newPath := filepath.Join(c.stateDir, "www", fmt.Sprint(delta.to.Version), "Manifest."+delta.to.Name)
return createDelta(c, oldPath, newPath, delta, bsdiffLog)
}
func createDelta(c *config, oldPath, newPath string, delta *Delta, bsdiffLog *log.Logger) error {
if _, err := os.Stat(delta.Path); err == nil {
// Skip existing deltas. Not verifying since client is resilient about that.
return nil
}
// Set timeout to 8 minutes (480 seconds) for bsdiff.
// The majority of all delta creations take significantly less than 8
// minutes; the deltas that take longer usually indicate that old/new
// files are large or very difficult to diff.
if err := helpers.RunCommandTimeout(480, "bsdiff", oldPath, newPath, delta.Path); err != nil {
_ = os.Remove(delta.Path)
if exitErr, ok := errors.Cause(err).(*exec.ExitError); ok {
// bsdiff returns 1 that stands for "FULLDL", i.e. it decided that
// a delta is not worth. Give a better error message for that case.
if status, ok := exitErr.Sys().(syscall.WaitStatus); ok {
if status.ExitStatus() == 1 {
return fmt.Errorf("bsdiff returned FULLDL, not using delta %s (%d-%s) -> %s (%d-%s)", delta.from.Name, delta.from.Version, delta.from.Hash, delta.to.Name, delta.to.Version, delta.to.Hash)
}
}
}
errStr := fmt.Sprintf("Failed to create delta for %s (%d-%s) -> %s (%d-%s)", delta.from.Name, delta.from.Version, delta.from.Hash, delta.to.Name, delta.to.Version, delta.to.Hash)
bsdiffLog.SetPrefix("BSDIFF: ")
bsdiffLog.Println(errStr)
return errors.Wrap(err, errStr)
}
// Check that delta is smaller than compressed full file
if deltaTooLarge(c, delta, newPath) {
_ = os.Remove(delta.Path)
errStr := fmt.Sprintf("Delta file larger than compressed full file %s (%d-%s) -> %s", delta.to.Name, delta.to.Version, delta.to.Hash, newPath)
bsdiffLog.SetPrefix("LARGER-DELTA: ")
bsdiffLog.Println(errStr)
return errors.New(errStr)
}
// Check that the delta actually applies correctly.
testPath := delta.Path + ".testnewfile"
if err := helpers.RunCommandSilent("bspatch", oldPath, testPath, delta.Path); err != nil {
errStr := fmt.Sprintf("Failed to apply delta %s", delta.Path)
bsdiffLog.SetPrefix("BSPATCH: ")
bsdiffLog.Println(errStr)
return errors.Wrapf(err, errStr)
}
defer func() {
_ = os.Remove(testPath)
}()
testHash, err := Hashcalc(testPath)
if err != nil {
_ = os.Remove(delta.Path)
return errors.Wrap(err, "Failed to calculate hash for test file created applying delta")
}
if testHash != delta.to.Hash {
_ = os.Remove(delta.Path)
return errors.Wrapf(err, "Delta mismatch: %s -> %s via delta: %s", oldPath, newPath, delta.Path)
}
return nil
}
func findDeltas(c *config, oldManifest, newManifest *Manifest) ([]Delta, error) {
oldManifest.sortFilesName()
newManifest.sortFilesName()
err := linkDeltaPeersForPack(c, oldManifest, newManifest)
if err != nil {
return nil, err
}
deltaCount := 0
for _, nf := range newManifest.Files {
if nf.DeltaPeer != nil {
deltaCount++
}
}
deltas := make([]Delta, 0, deltaCount)
// Use set to remove completely equal delta entries. These happen when two files that look
// the same, change content in next version (but still look the same).
seen := make(map[string]bool)
for _, nf := range newManifest.Files {
if nf.DeltaPeer == nil {
continue
}
from := nf.DeltaPeer
to := nf
dir := filepath.Join(c.outputDir, fmt.Sprint(to.Version), "delta")
name := fmt.Sprintf("%d-%d-%s-%s", from.Version, to.Version, from.Hash, to.Hash)
path := filepath.Join(dir, name)
if seen[path] {
continue
}
seen[path] = true
deltas = append(deltas, Delta{
Path: path,
from: from,
to: to,
})
}
return deltas, nil
}